Repository navigation
Add the Fixture fields from spec 1.13.82 - #11
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
The spec lists 20 fields on a fixture row and the model typed 13. Fixture gains reason, match_id, gender, is_qualifying, created_at, updated_at and pregame_forecasts. Match gains is_qualifying and pregame_forecasts. is_qualifying has three values. None means never stated, and None is not False. pregame_forecasts is sent on ULTRA only, so None means the field was absent. The package version stays as it is.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The spec at version 1.13.82 lists 20 fields on a fixture row. The
Fixturemodel typed 13 of them.Fixturegains seven fields:reason:str | None. One ofwalkover,retired,cancelled,default,postponed.match_id:int | None. The id of the match the fixture became.Noneuntil one exists.gender:str | None.menorwomen.Nonefor mixed events.is_qualifying:bool | None.Nonemeans never stated, andNoneis notFalse.created_at:datetime | None, UTC.updated_at:datetime | None, UTC.pregame_forecasts:list[dict] | None. ULTRA only. The field is absent below ULTRA.Matchgains two fields from the same spec era:is_qualifying:bool | None.pregame_forecasts:list[dict] | None. Sent on ULTRA upcoming list rows only.Notes for review
rawand attribute passthrough. They are now typed and documented.created_atandupdated_atjoin_datetime_fields, so they parse likestart_time.pregame_forecastsreadsNone. An empty list from the server stays[].Tests
pytest -q -m "not contract": 254 passed.ruff check src/ tests/andruff format --check src/: clean.sh scripts/truthcheck.sh: OK.